Make sure to update plugin information before disabling plugins #16416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I upgraded 3.14.1 to Matomo 4. Somehow Custom Variables was disabled afterwards. Then noticed: * We update core * We update plugins in a different request `action=oneClickUpdatePartTwo` * Then we check if there are incompatible plugins but I'm not sure if ever the updated plugin information is ever reloaded after updating the plugins in the previous action? I'm not sure though. According to this theory I would have also expected that other plugins were disabled.
|
tests look good, will merge and also apply to Matomo 4 |
tsteur
added a commit
that referenced
this pull request
Sep 10, 2020
tsteur
added a commit
that referenced
this pull request
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded 3.14.1 to Matomo 4.
Somehow Custom Variables was disabled afterwards. Then noticed:
action=oneClickUpdatePartTwoI'm not sure though. According to this theory I would have also expected that other plugins would have been disabled that were updated through the marketplace. Not sure how it worked for the marketplace plugins but not this one. There must be maybe some extra logic somewhere.
I think this used to work because when the marketplace plugin was updated, it used to reload the plugin see https://github.com/matomo-org/matomo/blob/3.14.1-rc1/plugins/CorePluginsAdmin/PluginInstaller.php#L73-L77
This used to be done in the same request. But since moving this out into a second request, the information is no longer updated. I think this is a regression from #15770