Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom variables and provider plugin.json #16415

Closed
wants to merge 2 commits into from
Closed

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 10, 2020

To undo #16319

What happens is that core seems to be upgraded to Matomo 4 code. At that point it does have the code already for Custom Variables 4.0

But then in https://github.com/matomo-org/matomo/blob/3.14.1-rc1/plugins/CoreUpdater/Updater.php#L170 it seems there is still somehow automated information as when I upgraded to Matomo 4 the CustomVariables plugin was automatically disabled for some reason.

So this PR aims to fix that when upgrading from 3.14.1 to Matomo 4 the Custom Variables might end up deactivated.

I'm not even sure how things work in general. I would have expected before that disable plugins code runs that somewhere all the plugin information is being updated. Like how does it know the information of the updated plugins in oneClickUpdatePartTwo.

To undo #16319

What happens is that core seems to be upgraded to Matomo 4 code. At that point it does have the code already for Custom Variables 4.0

But then in https://github.com/matomo-org/matomo/blob/3.14.1-rc1/plugins/CoreUpdater/Updater.php#L170 it seems there is still somehow automated information as when I upgraded to Matomo 4 the CustomVariables plugin was automatically disabled for some reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants