Remove custom variables and provider plugin.json #16415
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To undo #16319
What happens is that core seems to be upgraded to Matomo 4 code. At that point it does have the code already for Custom Variables 4.0
But then in https://github.com/matomo-org/matomo/blob/3.14.1-rc1/plugins/CoreUpdater/Updater.php#L170 it seems there is still somehow automated information as when I upgraded to Matomo 4 the CustomVariables plugin was automatically disabled for some reason.
So this PR aims to fix that when upgrading from 3.14.1 to Matomo 4 the Custom Variables might end up deactivated.
I'm not even sure how things work in general. I would have expected before that disable plugins code runs that somewhere all the plugin information is being updated. Like how does it know the information of the updated plugins in
oneClickUpdatePartTwo
.