Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove visit standard length from tracker #16412

Merged
merged 3 commits into from Sep 9, 2020
Merged

Remove visit standard length from tracker #16412

merged 3 commits into from Sep 9, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 9, 2020 •
edited

This was actually not needed because a ping doesn't extend the visit anyway and it makes things only more complicated when someone has a custom visit length. As discussed with Matt refs matomo-org/developer-documentation#382

@tsteur tsteur added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Sep 9, 2020
@tsteur
Copy link
Member Author

tsteur commented Sep 9, 2020

build js

@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Sep 9, 2020
@diosmosis diosmosis merged commit d89a202 into 4.x-dev Sep 9, 2020
@diosmosis diosmosis deleted the removestandardlength branch September 9, 2020 05:26
@mattab mattab added this to the 4.0.0 milestone Sep 10, 2020
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @diosmosis @mattab