Will be used to, for example, remove pending invalidations when a custom report is deleted. This will prevent starting climulti:requests for these custom report IDs.
LGTM if tests pass @diosmosis
btw are we also deleting them when a site is deleted? Although then maybe they would be simply skipped anyway?
Although then maybe they would be simply skipped anyway?
They should be skipped... I'll double check though.
@tsteur added a check for whether the site exists to the start of QueueConsumer::getNextArchivesToProcess(). This means it will run before getting a group of archives to process concurrently, so it won't be run too often (just before a batch of climulti:requests starts). Otherwise we'd check for every invalidation we pull from the table. Didn't think it was worth it given how unlikely this is to happen.
@diosmosis there's a test failing in https://travis-ci.org/github/matomo-org/matomo/jobs/725881962#L738 maybe the delete doesn't work 100% correct
failed copy paste