Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined offset in Matomo PHP Tracker #16397

Closed
tsteur opened this issue Sep 6, 2020 · 2 comments
Closed

Fix undefined offset in Matomo PHP Tracker #16397

tsteur opened this issue Sep 6, 2020 · 2 comments
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 6, 2020

( ! ) Notice: Undefined offset: 3 in vendor/piwik/piwik-php-tracker/PiwikTracker.php on line 1296

This is now happening in Matomo tracker because of https://github.com/matomo-org/matomo/pull/15774/files#diff-1279d666063b65e6d6777f902d11574fR3322-R3330

See https://github.com/matomo-org/matomo-php-tracker/blob/master/MatomoTracker.php#L1302-L1306

The cookie now has a lot less parts and different parts.

As part of this issue we need to

  • Assess if this breaks anything in PHP tracker (eg what happens if visitCount etc is no longer existing)
  • Adjust the PHP tracker code to understand both type of cookies (older visits would have old cookie structure vs some will have new cookie structure)
  • Mention in Matomo 4 developer changelog clearly that people need to upgrade their PHP tracker if they use it to not break anything
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 6, 2020
@tsteur tsteur added this to the 4.0.0 milestone Sep 6, 2020
@diosmosis diosmosis self-assigned this Sep 6, 2020
@diosmosis diosmosis mentioned this issue Sep 7, 2020
Closed
@diosmosis
Copy link
Member

diosmosis commented Sep 7, 2020 •
edited by Findus23

@tsteur created matomo-org/matomo-php-tracker#79
Note: doesn't break anything since we don't send those tracking params anymore. Users still need to update. After it's merged, I'll create a PR w/ the changelog info.

@diosmosis diosmosis mentioned this issue Sep 7, 2020
Merged
@mattab
Copy link
Member

mattab commented Sep 10, 2020

Also To do:

  • Create issues in all SDKs that have used the PHP code initially such as the C#, possibly Java SDK, and Python

This was referenced Sep 18, 2020
Closed
Closed
Open
@tsteur tsteur closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

handle new cookie values matomo-org/matomo-php-tracker
3 participants
@diosmosis @tsteur @mattab