New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take advantage of plugin specific archiving #16396
Comments
@tsteur fyi, AbTesting doesn't appear to have a created_date, is there another date that should be used or should created_date be added? |
@diosmosis as mentioned in chat |
@tsteur prs have all been created, awaiting review |
@sgiehl can you review the linked PRs in the issue description? Basically, when using CLI archiving, then it should rearchive the related plugin specific reports or archive it for reports in the past on plugin activation for example. |
done. Left some comments on some PRs |
I suppose we now only need to update the other plugins that were using the activate hook and then release a new version for each plugin (I can do that) and things should be done? |
@tsteur it's on my list for today |
@diosmosis does the funnels PR still need to be updated? |
@diosmosis also left a comment in custom reports to check |
This should be done now. There's one more comment left in custom reports to tweak a message ideally but can be done any time |
@diosmosis could you maybe look at this one? refs #11974
Custom reports
(not sure if done already both in create and update custom reports). Should only rearchive the specific reportPR: https://github.com/innocraft/plugin-CustomReports/pull/92
Users Flow
: on activation it should archive all it's reportsPR: https://github.com/innocraft/plugin-UsersFlow/pull/43
Multi Channel Conversion Attribution
: on activation it should archive all it's reportsPR: https://github.com/innocraft/plugin-MultiChannelConversionAttribution/pull/27
Funnels
: When adding or updating a funnel rearchive that specific funnelPR: https://github.com/innocraft/plugin-Funnels/pull/70
AbTesting
: When updating (not adding) an existing A/B test then it should rearchive the data for A/B testing. Ideally it would do this back untilabtest['created_date']
. (which is often just a few days or weeks instead of multiple months)PR: https://github.com/innocraft/plugin-AbTesting/pull/63
Cohorts
: On activation it should rearchive all it's reports (be good to confirm @diosmosis )PR: https://github.com/innocraft/plugin-Cohorts/pull/19
The text was updated successfully, but these errors were encountered: