Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of plugin specific archiving #16396

Closed
6 tasks done
tsteur opened this issue Sep 6, 2020 · 13 comments
Closed
6 tasks done

Take advantage of plugin specific archiving #16396

tsteur opened this issue Sep 6, 2020 · 13 comments
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Sep 6, 2020

@diosmosis could you maybe look at this one? refs #11974

@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 6, 2020
@tsteur tsteur added this to the 4.0.0 RC milestone Sep 6, 2020
@diosmosis diosmosis self-assigned this Sep 6, 2020
@diosmosis
Copy link
Member

@tsteur fyi, AbTesting doesn't appear to have a created_date, is there another date that should be used or should created_date be added?

@tsteur
Copy link
Member Author

tsteur commented Oct 14, 2020

@diosmosis as mentioned in chat start_date will need to be used. That's when the first tracking request for an a/b test has been received.

@diosmosis
Copy link
Member

@tsteur prs have all been created, awaiting review

@tsteur
Copy link
Member Author

tsteur commented Nov 3, 2020

@sgiehl can you review the linked PRs in the issue description? Basically, when using CLI archiving, then it should rearchive the related plugin specific reports or archive it for reports in the past on plugin activation for example.

@sgiehl
Copy link
Member

sgiehl commented Nov 3, 2020

done. Left some comments on some PRs

@tsteur
Copy link
Member Author

tsteur commented Nov 15, 2020

I suppose we now only need to update the other plugins that were using the activate hook and then release a new version for each plugin (I can do that) and things should be done?

@tsteur
Copy link
Member Author

tsteur commented Nov 15, 2020

@diosmosis @sgiehl

@diosmosis
Copy link
Member

@tsteur it's on my list for today

@diosmosis
Copy link
Member

@tsteur @sgiehl plugins that use this functionality should be updated in PRs (UsersFlow, MultiChannelConversionAttribution, Cohorts)

@diosmosis
Copy link
Member

@tsteur @sgiehl PRs updated again

@tsteur
Copy link
Member Author

tsteur commented Nov 18, 2020

@diosmosis does the funnels PR still need to be updated?

@tsteur
Copy link
Member Author

tsteur commented Nov 18, 2020

@diosmosis also left a comment in custom reports to check

@tsteur
Copy link
Member Author

tsteur commented Nov 23, 2020

This should be done now. There's one more comment left in custom reports to tweak a message ideally but can be done any time

@tsteur tsteur closed this as completed Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

3 participants