Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix randomly failing test diagnostic page UI test #16390

Merged
merged 1 commit into from Sep 4, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 4, 2020

Depending of the time of the day it returns 0 or 1. There might be better ways to fix this but thought to keep it simple. Happy to change if needed.

https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/42269/Diagnostics_page.png

Depending of the time of the day it returns 0 or 1. There might be better ways to fix this but thought to keep it simple. Happy to change if needed.

https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/42269/Diagnostics_page.png
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 4, 2020
@tsteur tsteur added this to the 4.0.0 milestone Sep 4, 2020
@diosmosis diosmosis merged commit 59dcbb6 into 4.x-dev Sep 4, 2020
@diosmosis diosmosis deleted the fixuitestdiagpage branch September 4, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants