Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the same 2FA token cannot be used twice #16389

Merged
merged 1 commit into from Sep 4, 2020
Merged

Make sure the same 2FA token cannot be used twice #16389

merged 1 commit into from Sep 4, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 4, 2020

No description provided.

@tsteur tsteur added the Needs Review PRs that need a code review label Sep 4, 2020
@tsteur tsteur added this to the 4.0.0 RC milestone Sep 4, 2020
@tsteur
Copy link
Member Author

tsteur commented Sep 4, 2020

i'll fix the randomly failing test https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/42269/Diagnostics_page.png in a different PR

@diosmosis diosmosis merged commit c3c465a into 4.x-dev Sep 4, 2020
@diosmosis diosmosis deleted the twofatokentwice branch September 4, 2020 06:06
@mattab mattab modified the milestones: 4.0.0-RC, 4.0.0 Sep 28, 2020
@mattab mattab added the c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @diosmosis @mattab