Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to use matomo require when generating components #16388

Merged
merged 1 commit into from Sep 4, 2020
Merged

Make sure to use matomo require when generating components #16388

merged 1 commit into from Sep 4, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 4, 2020

I generated a plugin in Matomo 4 and it created this:

image

Instead it should now always use "matomo".

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 4, 2020
@tsteur tsteur added this to the 4.0.0 milestone Sep 4, 2020
@diosmosis diosmosis merged commit ee1fe40 into 4.x-dev Sep 4, 2020
@diosmosis diosmosis deleted the generateplugin branch September 4, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis