Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urgent update to Danish translation #16382

Merged
merged 1 commit into from Sep 4, 2020
Merged

Urgent update to Danish translation #16382

merged 1 commit into from Sep 4, 2020

Conversation

atjn
Copy link

@atjn atjn commented Sep 4, 2020

I understand that you usually don't accept translation fixes directly in GitHub, but given that you don't update the translations for 3.x anymore, and that this is a pretty urgent issue, @sgiehl suggested that i should also create a direct PR for this fix.

The danish translation will curently tell the user that they have opted out of tracking, even though they are still opted in. We are basically lying to the user, which is not very nice, and also illegal.

The specific string is CoreAdminHome.YouAreNotOptedOut.
The current danish translation says (re-translated back to english): "You have now opted out of cookies."
My new danish translation says (re-translated back to english): "You are allowing tracking."

The string CoreAdminHome.YouAreOptedOut also has a minor issue. It specifically mentions cookies, but this mechanism does not just disable cookies, it disables all tracking.
The current danish translation says (re-translated back to english): "You have opted out of cookies for web analysis."
My new danish translation says (re-translated back to english): "You have opted out of tracking."

The strings CoreAdminHome.UncheckToOptOut and CoreAdminHome.CheckToOptIn are also updated, simply to align with the new wording.

@tsteur
Copy link
Member

tsteur commented Sep 4, 2020

Thanks @atjn very much appreciated

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 4, 2020
@tsteur tsteur merged commit 676a5ca into matomo-org:3.x-dev Sep 4, 2020
@mattab mattab added this to the 3.14.1 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants