Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 3.X into 4.X #16378

Merged
merged 6 commits into from Sep 3, 2020
Merged

Merge 3.X into 4.X #16378

merged 6 commits into from Sep 3, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 3, 2020

No description provided.

tsteur and others added 3 commits August 25, 2020 19:06
* Fix plugins might not be updated when updating core

* dont invalidate all caches as it could have side effects re template etc

* dont invalidate cache

* fix error if marketplace is not enabled, fallback to direct dispatch if climulti doesnt work

* show update log

* fix test
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 3, 2020
@tsteur tsteur merged commit 3ebaf87 into 4.x-dev Sep 3, 2020
@tsteur tsteur deleted the 3xdev branch September 3, 2020 23:58
@sgiehl
Copy link
Member

sgiehl commented Sep 4, 2020

@tsteur It's better not to use Pull Request to merge changes from 3.x-dev to 4.x-dev. The next time someone tries to do another merge from 3.x-dev the same commits will be tried to merge again, as they were squashed when merging the PR and thus they don't exsist in 4.x-dev. I usual do the merge on a second branch to check the travis build, but push the merge on 4.x-dev directly

@tsteur
Copy link
Member Author

tsteur commented Sep 6, 2020

👍 forgot about that one. Will do next time. I reckon in this case it was likely (hopefully) the last time we had to merge 3.x into 4.x and instead issue separate PRs if needed or so

@mattab mattab added this to the 4.0.0 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants