Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer feature to anonymise or shorten the referrer #16376

Merged
merged 12 commits into from Oct 1, 2020
Merged

Offer feature to anonymise or shorten the referrer #16376

merged 12 commits into from Oct 1, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 3, 2020

fix #15426

Offers 4 ways to anonymise the referrer. For debugging purposes it also shows the anonymise referrer config in system check and it's also showing it in the referrer reports as a footer note that the data is anonymised.

When don't store referrer URL is configured it will still detect the type of referrer (eg search vs social) and it also keeps the name of the search engine or social network as this should be fine and not be any PII. Campaign info is provided from the current URL not the referrer so this is not impacted by this setting (neither when specifically tracking a campaign info through HTTP API tracking parameters such as _rcn).

When no referrer URL is stored in the website URL it may look bit funny but at least it shows a footer note (not shown in the screenshot)
image

@tsteur tsteur added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Sep 3, 2020
@tsteur tsteur marked this pull request as draft September 3, 2020 20:10
if (SettingsPiwik::isMatomoInstalled()) {
$config = new Config();

$results[] = DiagnosticResult::informationalResult('Anonymize Referrer', $config->anonymizeReferrer);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not translated as it's mostly info for us

@tsteur tsteur added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Sep 16, 2020
@tsteur tsteur marked this pull request as ready for review September 16, 2020 23:53
@tsteur tsteur added this to the 4.0.0 RC milestone Sep 16, 2020
@tsteur
Copy link
Member Author

tsteur commented Sep 30, 2020

@sgiehl applied the changes

@tsteur tsteur merged commit 06d4385 into 4.x-dev Oct 1, 2020
@tsteur tsteur deleted the mprivacy branch October 1, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer feature to anonymise or shorten the referrer
2 participants