New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer feature to anonymise or shorten the referrer #16376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
the
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
label
Sep 3, 2020
tsteur
commented
Sep 16, 2020
if (SettingsPiwik::isMatomoInstalled()) { | ||
$config = new Config(); | ||
|
||
$results[] = DiagnosticResult::informationalResult('Anonymize Referrer', $config->anonymizeReferrer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not translated as it's mostly info for us
tsteur
added
Needs Review
PRs that need a code review
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
and removed
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
labels
Sep 16, 2020
sgiehl
requested changes
Sep 30, 2020
@sgiehl applied the changes |
sgiehl
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Review
PRs that need a code review
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15426
Offers 4 ways to anonymise the referrer. For debugging purposes it also shows the anonymise referrer config in system check and it's also showing it in the referrer reports as a footer note that the data is anonymised.
When
don't store referrer URL
is configured it will still detect the type of referrer (eg search vs social) and it also keeps the name of the search engine or social network as this should be fine and not be any PII. Campaign info is provided from the current URL not the referrer so this is not impacted by this setting (neither when specifically tracking a campaign info through HTTP API tracking parameters such as_rcn
).When no referrer URL is stored in the website URL it may look bit funny but at least it shows a footer note (not shown in the screenshot)