Make sure query in system check uses index #16372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
the
not-in-changelog
diosmosis
reviewed
Sep 2, 2020
| @@ -54,7 +56,8 @@ private function hadVisitsInLastDays($numDays) | |||
| $time = Date::now()->subDay($numDays)->getDatetime(); | |||
|
|
|||
| try { | |||
| $row = Db::fetchOne('SELECT idsite from ' . $table . ' where visit_last_action_time > ? LIMIT 1', $time ); | |||
| $idSites = $this->getImplodedIdSitesSecure(); | |||
There was a problem hiding this comment.
Not sure about this, but could we also use the index if we just did something like, AND idsite > 0?
There was a problem hiding this comment.
AFAIK Mysql doesn't support using both index parts (idsite and visit_last_action_time) when both are a range. MySQL stops using the index after the first range. So idsite > 0 would be a range and therefore it would only use the idsite index.
There was a problem hiding this comment.
In that case, can Site::getIdSitesFromIdSitesString('all') be used (w/ superuser access) to get all of them? Not really necessary, but might use existing cached data and reduce amount of code here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fyi @diosmosis