Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the incorrect tooltips in Visitors > Overview #16371

Closed
mattab opened this issue Sep 2, 2020 · 4 comments · Fixed by #17040
Closed

Remove the incorrect tooltips in Visitors > Overview #16371

mattab opened this issue Sep 2, 2020 · 4 comments · Fixed by #17040
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Sep 2, 2020

in the Visitors > Overview report (eg. on demo) the tooltips to the metrics on the right are all incorrect:

-> Let's remove these tooltips on

x pageviews, 0 unique pageviews
x total searches on your website, 0 unique keywords
x downloads, 0 unique downloads
x outlinks, 0 unique outlinks

@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Sep 2, 2020
@mattab mattab added this to the 4.1.0 milestone Sep 2, 2020
@sgiehl
Copy link
Member

sgiehl commented Nov 27, 2020

The shown tooltips are actually the default documentation for each of those metrics. So if it doesn't match it might also not match in other places. For downloads & outlinks we currently reuse the same documentation:

'nb_pageviews' => 'General_ColumnPageviewsDocumentation',
'nb_uniq_pageviews' => 'General_ColumnUniquePageviewsDocumentation',
'nb_downloads' => 'Actions_ColumnClicksDocumentation',
'nb_uniq_downloads' => 'Actions_ColumnUniqueClicksDocumentation',
'nb_outlinks' => 'Actions_ColumnClicksDocumentation',
'nb_uniq_outlinks' => 'Actions_ColumnUniqueClicksDocumentation',
'nb_searches' => 'Actions_ColumnSearchesDocumentation',
'avg_time_generation' => 'General_ColumnAverageGenerationTimeDocumentation',
'entry_nb_visits' => 'General_ColumnEntrancesDocumentation',
'entry_bounce_count' => 'General_ColumnBouncesDocumentation',
'exit_nb_visits' => 'General_ColumnExitsDocumentation',
'exit_rate' => 'General_ColumnExitRateDocumentation'

Guess it would be better to maybe go through the metrics glossary and fix all documentations that don't fit or can be improved

@tsteur
Copy link
Member

tsteur commented Nov 29, 2020

Let's maybe for now fix just those ones and later eventually we'll go through all of them when needed.

@sgiehl
Copy link
Member

sgiehl commented Nov 30, 2020

Just thought about how to improve that documentation. But actually it's a bit hard to find something that matches all use cases. Those documentation is used as column documentation in data tables as well. For that case most documentations kind of match (even though some could be improved). But for the sparklines they have a slightly other meaning.
For the table we often use something like The number of visits that clicked this link, but for the overall sparkline it would be more something like The number of visits that clicked any link

@tsteur
Copy link
Member

tsteur commented Nov 30, 2020

Can we change the translation for the sparklines eg in VisitsSummary/get like if $view is sparklines then $view->addTranslation...? It be a bit of work but seems there's no other way?

@mattab mattab modified the milestones: 4.1.0, 4.2.0 Dec 21, 2020
@sgiehl sgiehl self-assigned this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants