Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS error in materialize in dropdown #16370

Closed
tsteur opened this issue Sep 2, 2020 · 2 comments · Fixed by #16593
Closed

JS error in materialize in dropdown #16370

tsteur opened this issue Sep 2, 2020 · 2 comments · Fixed by #16593
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0-RC

Comments

@tsteur
Copy link
Member

tsteur commented Sep 2, 2020

refs #16368

image

when calling .dropdown

image

then it fails here:
image

Noticed this in ?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=day&date=2019-11-28&segment=&category=Goals_Ecommerce&subcategory=MultiChannelConversionAttribution_MultiAttribution

when I selected an attribution model

image

I can't reliably reproduce it so far though and things seem to still generally work so we may be able to ignore it for now. Might be some race condition or so.
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 2, 2020
@tsteur tsteur added this to the 4.0.0 RC milestone Sep 2, 2020
@diosmosis diosmosis self-assigned this Oct 19, 2020
@diosmosis
Copy link
Member

@tsteur I think I found the issue here, it fails if a datatable is loading, and before it finishes loading, we re-load the datatable in some way. So:

  1. datatable is starting to reload because of some change (eg, attribution dropdown changed)
  2. before datatable is finished reloading, another dropdown is used, causing new reload
  3. since the content for the first datatable reloaded is never added to the dom (or is added and replaced w/ a loading gif), the dropdownConfiguration dropdown fails to find a specific element, causing it to throw

not yet sure if there's a quick fix

@diosmosis
Copy link
Member

found a quick fix

@diosmosis diosmosis mentioned this issue Oct 20, 2020
Merged
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging a pull request may close this issue.

Do not always initialize dropdown element if the element is no longer on the page. matomo-org/matomo
3 participants
@diosmosis @tsteur @mattab