Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep MaterializeCSS up to date #16368

Closed
tsteur opened this issue Sep 2, 2020 · 4 comments · Fixed by #19622
Closed

Keep MaterializeCSS up to date #16368

tsteur opened this issue Sep 2, 2020 · 4 comments · Fixed by #19622
Assignees
@sgiehl
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
5.0.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 2, 2020

I noticed in the 4.X branch there are sometimes JS errors in Materialize lib … Will keep an eye on it when it happens again… checked if there’s a new release available but see Dogfalo/materialize#6438 there are 200 open PRs, 600 open issues and no new release in 1-2 years. Seems the maintainers only create releases for people donating or don't do anything at all anymore. Seems a fork will be maybe continued in https://github.com/materializecss/materialize but we’ll need to see if actually something will happen.
@tsteur tsteur added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Sep 2, 2020
This was referenced Sep 2, 2020
Closed
Closed
@Findus23 Findus23 mentioned this issue May 12, 2021
Closed
@Findus23
Copy link
Member

I just noticed that an alpha release of the fork was released (https://github.com/materializecss/materialize/releases/tag/1.1.0-alpha). So I guess once it is stable, Matomo could use the fork.

@sgiehl
Copy link
Member

sgiehl commented May 12, 2021

might be worth a try to simply replace the library on a branch and check if UI tests are still working

@Findus23 Findus23 mentioned this issue May 16, 2021
Open
@tsteur tsteur added this to the 5.0.0 milestone Nov 22, 2021
@tsteur
Copy link
Member Author

tsteur commented Apr 20, 2022

FYI After 4 years Materialize finally released an update :) https://github.com/materializecss/materialize/releases/tag/1.1.0

@sgiehl
Copy link
Member

sgiehl commented Apr 26, 2022

I spent a couple of minutes preparing the required changes to use the fork. If tests are (still) passing we could maybe consider doing that before Matomo 5.
https://github.com/matomo-org/matomo/pull/new/materializeupdate

@sgiehl sgiehl mentioned this issue Aug 12, 2022
Merged
11 tasks
@sgiehl sgiehl self-assigned this Aug 12, 2022
@mattab mattab added the 5.0.0 label Jan 4, 2023
@sgiehl sgiehl changed the title Keep MaterializeCSS up to date - use a fork or replace library Keep MaterializeCSS up to date May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Use materializecss/materialize instead of Dogfalo/materialize matomo-org/matomo
4 participants
@tsteur @mattab @sgiehl @Findus23