Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace search broken in Reports #16358

Closed
Findus23 opened this issue Aug 31, 2020 · 5 comments
Closed

Marketplace search broken in Reports #16358

Findus23 opened this issue Aug 31, 2020 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.0.0-RC

Comments

@Findus23
Copy link
Member

This seems broken in both 3.x and 4.x: When opening the Marketplace via the reports instead of the admin settings (I'm still not sure if this duplication is helpful) the plugin search seems broken
grafik

It redirects to

https://matomo.dev/index.php?module=Marketplace&action=overview&embed=1&idSite=17&period=month&date=today&segment=&showtitle=1&random=3659&sort=

which is not a full page, but just an HTML widget.
@Findus23 Findus23 added the Bug For errors / faults / flaws / inconsistencies etc. label Aug 31, 2020
@tsteur
Copy link
Member

tsteur commented Aug 31, 2020

@Findus23 I just tried to reproduce this on 3.X on the demo but couldn't. It shows correctly the content on the right side just like a report. Only an HTML widget be expected as it's not supposed to be a full page but shown just like a report. Not sure if I maybe not understand something correctly?

@Findus23

This comment has been minimized.

Sign in to view
@tsteur tsteur added this to the 4.0.0 RC milestone Aug 31, 2020
@tsteur
Copy link
Member

tsteur commented Aug 31, 2020

I'd say for simplicity when someone searches for a plugin then we load the dedicated page maybe. This means we likely only need to set the correct action in the form

@tsteur tsteur modified the milestones: 4.0.0 RC, 3.14.1 Aug 31, 2020
@tsteur
Copy link
Member

tsteur commented Aug 31, 2020

This should be fixed in a1e7949

@tsteur tsteur closed this as completed Aug 31, 2020
@Findus23
Copy link
Member Author

Findus23 commented Sep 1, 2020

I can confirm it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.0.0-RC
Development

No branches or pull requests
2 participants
@tsteur @Findus23