Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make number fields look the same as text fields #16357

Merged
merged 1 commit into from Aug 31, 2020
Merged

Make number fields look the same as text fields #16357

merged 1 commit into from Aug 31, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 31, 2020

Having a field of type text and number on the same line currently lets the fields look slightly different.

image

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Aug 31, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Aug 31, 2020
@tsteur tsteur merged commit 123adba into 4.x-dev Aug 31, 2020
@tsteur tsteur deleted the numberfields branch August 31, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur