use localized country names for segment selector #16355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Findus23
added
c: Usability
|
@Findus23 Using translated properties in segments might break easily as the translated name is part of the segment definition. As soon as one switches the languages or tries to share the segment with someone not using the same language the segment won't work anymore |
|
@sgiehl That makes sense. I (baselessly) assumed that only the country code instead of the name would be stored in the segment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be a reason why this wasn't done initially, but I personally find it more accessible for people to see the country names in their language and ordered alphabetically instead of by country code
Before:
After:
If this is intentional, then you can simply close this PR.