Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "learn more" link on DB Usage summary #16351

Closed
wants to merge 1 commit into from

Conversation

aitorres
Copy link

@aitorres aitorres commented Aug 28, 2020

This PR attempts to fix and close #16339, by changing the URL that is linked to on the Database Usage summary table to the right one.

The change introduced follows Findus23's comment / hint on said issue.

@tsteur
Copy link
Member

tsteur commented Aug 28, 2020

@aitorres if I understand things correctly then this would change the link everywhere in all data table reports. However, the link is basically correct everywhere except DB stats so only there should the link be changed.

@Findus23
Copy link
Member

@aitorres Sorry, that I didn't make that clear enough.
I meant that it seems like this link is generated by the normal help that appears at the end of all reports (and is correct there). So changing the URL isn't enough, but one would have to detect the special case and only replace the URL (or maybe even remove it) in the DB usage tables.

@tsteur
Copy link
Member

tsteur commented Aug 30, 2020

@aitorres not sure if you still want to work on this issue considering it will be more difficult or should we close the PR?

@tsteur tsteur added the Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. label Aug 31, 2020
@tsteur
Copy link
Member

tsteur commented Sep 25, 2020

@aitorres are you still working on this one? Simply let us know if not and we can close the PR

@aitorres
Copy link
Author

Hello @tsteur, I'm sorry for not replying before. I think I will not be able to continue on the issue / PR, so I will proceed to closing it. Again, I'm sorry for the inconveniences. I hope to collaborate more / better in the future, and wish you luck!

@aitorres aitorres closed this Sep 28, 2020
@mattab mattab added this to the 4.0.0 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "learn more" in Database Usage page, or link to the right FAQ
4 participants