@aitorres opened this Pull Request on August 28th 2020

This PR attempts to fix and close #16339, by changing the URL that is linked to on the Database Usage summary table to the right one.

The change introduced follows Findus23's comment / hint on said issue.

@tsteur commented on August 28th 2020 Member

@aitorres if I understand things correctly then this would change the link everywhere in all data table reports. However, the link is basically correct everywhere except DB stats so only there should the link be changed.

@Findus23 commented on August 30th 2020 Member

@aitorres Sorry, that I didn't make that clear enough.
I meant that it seems like this link is generated by the normal help that appears at the end of all reports (and is correct there). So changing the URL isn't enough, but one would have to detect the special case and only replace the URL (or maybe even remove it) in the DB usage tables.

@tsteur commented on August 30th 2020 Member

@aitorres not sure if you still want to work on this issue considering it will be more difficult or should we close the PR?

@tsteur commented on September 25th 2020 Member

@aitorres are you still working on this one? Simply let us know if not and we can close the PR

@aitorres commented on September 28th 2020

Hello @tsteur, I'm sorry for not replying before. I think I will not be able to continue on the issue / PR, so I will proceed to closing it. Again, I'm sorry for the inconveniences. I hope to collaborate more / better in the future, and wish you luck!

This Pull Request was closed on September 28th 2020
Powered by GitHub Issue Mirror