Provide more debug information in system check #16350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
the
Pull Request WIP
tsteur
added
Needs Review
tsteur
commented
Aug 28, 2020
tsteur
commented
Aug 28, 2020
tsteur
commented
Aug 30, 2020
| $results = []; | ||
|
|
||
| if (SettingsPiwik::isMatomoInstalled()) { | ||
| $results[] = DiagnosticResult::informationalResult('Browser Archiving Enabled', Rules::isBrowserTriggerEnabled()); |
There was a problem hiding this comment.
fyi we don't really want to translate them likely cause it's mostly information for us... makes it easier to analyze things having it in english
tsteur
added
Pull Request WIP
tsteur
added
Needs Review
diosmosis
reviewed
Sep 2, 2020
diosmosis
reviewed
Sep 2, 2020
| $time = Date::now()->subDay($numDays)->getDatetime(); | ||
|
|
||
| try { | ||
| $row = Db::fetchOne('SELECT count(idsite) from ' . $table . ' where visit_last_action_time > ? LIMIT 1', $time ); |
There was a problem hiding this comment.
I could be wrong, but won't this still count every visit after the date? Should it be SELECT idsite FROM ... LIMIT 1?
tsteur
commented
Sep 2, 2020
| $time = Date::now()->subDay($numDays)->getDatetime(); | ||
|
|
||
| try { | ||
| $row = Db::fetchOne('SELECT idsite from ' . $table . ' where visit_last_action_time > ? LIMIT 1', $time ); |
There was a problem hiding this comment.
fyi @diosmosis I just realised this won't use an index. will provide a fix tmrw so it uses the index
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15931
Since we will run into few issues once people upgrade to Matomo 4 I reckon this will be actually quite valuable. It proved invaluable so far for any Matomo for WordPress problem. Eventually can add more like how "Diagnostics" plugin can already identify any customised config setting etc.