@tsteur opened this Pull Request on August 26th 2020 Member

eg by executing http://domain/tests/javascript/?plugin=HeatmapSessionRecording. In the past I always patched the index.php code manually but figured it be easier to have an option for this. That's because some plugin tests might not be compatible with each other as every JS adds different HTML code to the test. Eg when it runs Form Analytics, Heatmaps, Ab Tests, etc all in one go then the tests might not pass but they pass when executed independently. It doesn't fail because of any JS logic but because of the extra HTML they add to the file. It's possible this could be fixed but might be a bit of work. Will see first if I can get them to pass altogether.

Nonetheless sometimes it might be useful to have this opportunity to only add specific tests to the test page. It lets you eg execute tests just like Travis would do (when it runs the tests only for one plugin but not all plugins)

@tsteur commented on August 27th 2020 Member

note I also now fixed the tracker tests so they work mostly altogether. However, the plugin parameter as introduced by this PR will still be needed when trying to reproduce tests that fail on travis as it basically allows executing the tests just like travis:

  • Core JS tracker tests
  • Tag Manager JS tests
  • The JS tests for a specific plugin

without including any JS tests of other plugins and without including the head.php part of any other tests.

@tsteur commented on August 31st 2020 Member

fyi I'll merge this one since it's only for tests anyway

This Pull Request was closed on August 31st 2020
Powered by GitHub Issue Mirror