New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Call to undefined method Piwik\\DataTable\\Simple::getComparisons() #16342
Comments
@tsteur where did this URL come from? It's failing because of period=day&date=date1,date2 (ie, it's a multi-period query). I think the |
@diosmosis it looks like it came from this:
|
@tsteur is the sparklines visualization meant to be used with multi periods? |
Haven't looked how it works but would have expected that |
|
@diosmosis not sure what you mean with multi period? The request URL looks normal I just compared it to a regular request. Why it returned a datatable map not sure. Maybe it does think there's somewhere a multi period or some other issue. The URL was generated by the UI though and also looks good. Maybe some issue with a plugin or something, not sure. We can look into it after the Matomo 4 release though. |
There are two visualizations, one is EDIT: |
I guess we could make the sparklines visualization work when a multi period is used by summing up the datatable\map, but I don't think it natively supports it and I don't think the period selector UI supports clicking through to such a period. |
If the generated URL is not correct and it's using a multi period, then we'd need to maybe check how the UI would generate this URL as it's maybe a mistake. I'm pretty certain this URL wasn't generated by the user since the request came from our UI. Not too important right now though. |
That actually happens when you call the goals page with "invalid" parameters. e.g. something like Most of the charts actually throw an error in that case. Might be something we could handle better, like not requesting any reports at all and open the date selector directly if the date and period parameter combination isn't supported |
Sounds good @sgiehl . We could also just show a simple message like "specified date/period combination not supported. please choose a valid date range from the date selector". If it's not trivial we can also simply close the issue though as a wontfix |
Reopening this issue again as it's still a problem. Removing the milestone as we'll work on it only if it happens more often
|
On request
index.php?forceView=1&viewDataTable=sparklines&module=Goals&action=get&idGoal=10&allow_multiple=0&only_summary=1&idSite=2&period=day&date=2020-08-17,2020-08-23&segment=&showtitle=1&random=8740
following error happened because a data table map was returned instead of a regular data table. And in this case the first row is a dataTable and not a row.
The text was updated successfully, but these errors were encountered: