Use relative URLs for svgBasePath so proxy url doesn't need to be configured to make real time map work #16341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs matomo-org/matomo-for-wordpress#335 and #12623 This way it isn't needed to configure proxy headers for the real time map.
sgiehl
approved these changes
Aug 25, 2020
sgiehl
approved these changes
Aug 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs matomo-org/matomo-for-wordpress#335 and #12623
This way it isn't needed to configure proxy headers for the real time map. The regular map seems to already use the relative path like this.
It won't fix the Matomo
logo.svgnot being loaded correctly andgetMatomoUrl()would still return the wrong URL if not configured properly (eg in emails) but at least this way it's not always needed to configure it as at least the reporting works without configuring proxy headers.