Adjustments for CustomReports plugin #16340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
wouldn't that be expected? or you mean when requesting the API with format metrics off? |
tsteur
reviewed
Aug 24, 2020
| @@ -418,7 +418,7 @@ public function groupValue($value, $idSite) | |||
| case Dimension::TYPE_BOOL: | |||
| return !empty($value) ? '1' : '0'; | |||
| case Dimension::TYPE_DURATION_MS: | |||
| return number_format($value / 1000, 2); // because we divide we need to group them and cannot do this in formatting step | |||
| return number_format($value / 1000, 2) * 1000; // because we divide we need to group them and cannot do this in formatting step | |||
There was a problem hiding this comment.
Not sure why we divide by 1000 in the first place then @sgiehl ?
|
I guess to group them. Otherwise there would be multiple different values
ending up in the same formatted value... Eg. 1246ms and 1249ms would both
be formatted as 1.24s
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making CustomReport plugin compatible with Matomo 4, I've noticed a few dimensions/metrics having incorrect values.
Metrics using a custom sqlSegment like
daysSinceFirstVisitare archived incorrectly. As archiving currently uses the plain field value all metrics using custom sqlSegments and those based on them are incorrect. Using thesqlSegmentin ArchiveMetrics::getSql() fixes that problem.Dimensions in milliseconds like the new performance metrics are showing 0 values (when used as dimension), as they are grouped incorrectly. The grouping already divided them by 1000, causing the formatting to 0 the values, as it divides them another time. Grouping them in 1000 segments instead seems more correct.
The pagviews with performance timings metrics had an incorrect type, causing them formatted as time instead of number