Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "learn more" in Database Usage page, or link to the right FAQ #16339

Open
mattab opened this issue Aug 23, 2020 · 1 comment
Open

Remove "learn more" in Database Usage page, or link to the right FAQ #16339

mattab opened this issue Aug 23, 2020 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
5.x.0 - Priority ...

Comments

@mattab
Copy link
Member

mattab commented Aug 23, 2020

The DBStats is a great feature that gives a quick consistent overview of DB usage. There is only a small issue, in the report at eg. https://demo.matomo.org/index.php?module=DBStats&action=index&date=today&period=week&idSite=1 -

Got: It shows this link on hover:
image
and links to https://matomo.org/faq/how-to/faq_54/

Expected instead, link to https://matomo.org/docs/managing-your-databases-size/
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Aug 23, 2020
@tsteur tsteur added this to the 4.3.0 milestone Aug 23, 2020
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Aug 23, 2020
@Findus23
Copy link
Member

This doesn't seem to be any code specific to DBStats, but rather caused by

matomo/plugins/CoreHome/javascripts/dataTable.js

Lines 1819 to 1835 in d0aaab9

handleSummaryRow: function (domElem) {
var details = _pk_translate('General_LearnMore', [' (<a href="https://matomo.org/faq/how-to/faq_54/" rel="noreferrer noopener" target="_blank">', '</a>)']);
domElem.find('tr.summaryRow').each(function () {
var labelSpan = $(this).find('.label .value').filter(function(index, elem){
return $(elem).text() != '-';
}).last();
var defaultLabel = labelSpan.text();
$(this).hover(function() {
labelSpan.html(defaultLabel + details);
},
function() {
labelSpan.text(defaultLabel);
});
});
},

@aitorres aitorres mentioned this issue Aug 28, 2020
Closed
@mattab mattab changed the title "learn more" in Database Usage page links to the wrong FAQ Remove "learn more" in Database Usage page, or link to the right FAQ Dec 11, 2023
@mattab mattab added the c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
5.x.0 - Priority issues
Development

Successfully merging a pull request may close this issue.

fix "learn more" link on DB Usage summary aitorres/matomo
3 participants
@tsteur @mattab @Findus23