Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin.json files where needed #16319

Merged
merged 1 commit into from Aug 18, 2020
Merged

Add plugin.json files where needed #16319

merged 1 commit into from Aug 18, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 18, 2020

follow up from #16315 for 2.X

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 18, 2020
@tsteur tsteur merged commit cf94d48 into 2.x-dev Aug 18, 2020
@tsteur tsteur deleted the plugininfo branch August 18, 2020 21:19
tsteur added a commit that referenced this pull request Sep 10, 2020
To undo #16319

What happens is that core seems to be upgraded to Matomo 4 code. At that point it does have the code already for Custom Variables 4.0

But then in https://github.com/matomo-org/matomo/blob/3.14.1-rc1/plugins/CoreUpdater/Updater.php#L170 it seems there is still somehow automated information as when I upgraded to Matomo 4 the CustomVariables plugin was automatically disabled for some reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant