Tests no memory limit #16314
Merged
Tests no memory limit #16314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Findus23
added
c: Tests & QA
tsteur
reviewed
Aug 17, 2020
| @@ -145,6 +145,16 @@ public function test_Console_ReturnsCorrectExitCode_IfCommandDoesNotEmitAnything | |||
|
|
|||
| public function test_Console_handlesFatalErrorsCorrectly() | |||
| { | |||
| $cliPhp = new CliPhp(); | |||
There was a problem hiding this comment.
@Findus23 I suppose ini_get('memory_limit'); didn't work there?
There was a problem hiding this comment.
It doesn't as this is not calling the current PHP binary, but a separate php binary picked by $cliPhp->findPhpBinary which doesn't have to be the same (in my case it crashed the PC the first few times because I didn't notice that it was calling php7.4 while I was running the tests with php8). Therefore, I am checking the memory limit of the php binary that will be called in the test.
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing around with php8, I stumbled across 7960333 which is a test that tries to force a
PHP Fatal error: Allowed memory size of X bytes exhaustedon php-cli.Unfortunately, on my system (and probably others too) php-cli has a memory_limit of
-1which means the PC will run out of memory before one can notice what command is running.This PR adds a slight hack to skip this test in this case.