Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove optional parameter before required one #16312

Merged
merged 1 commit into from Aug 17, 2020
Merged

remove optional parameter before required one #16312

merged 1 commit into from Aug 17, 2020

Conversation

Findus23
Copy link
Member

refs #16183 (PHP 8 support)

[17-Aug-2020 14:19:19 UTC] PHP Deprecated: Required parameter $actionsTablesByType follows optional parameter $urlPrefix in /home/lukas/public_html/matomophp8/plugins/Actions/ArchivingHelper.php on line 374

As this is only called in one place, this should not break anything. If there is an easier way to fix this, let me know.

@Findus23 Findus23 added the Needs Review PRs that need a code review label Aug 17, 2020
@Findus23 Findus23 mentioned this pull request Aug 17, 2020
Closed
6 tasks
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 17, 2020
@tsteur tsteur merged commit 7e06890 into 4.x-dev Aug 17, 2020
@tsteur tsteur deleted the getActionRow-optional-parameter branch August 17, 2020 19:51
@mattab mattab added this to the 4.0.0 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Findus23 @tsteur @mattab