@diosmosis be good to add a test eg with segments that contains characters like ' " & < > to check it doesn't break anything there? The segment definition would be set when archiving.

@tsteur ArchiveCronTest should archive segments (segments defined in ManySitesImportedLogs::getDefaultSegments()). is that enough?

@diosmosis I'm not sure. they don't seem to be encoded the way they are usually? Eg the 2 archives visitCount<=5;visitorType!=re%2C%3Btest%20is%20encoded;daysSinceFirstVisit<=50 and visitCount<=5;visitorType!=non-existing-type;daysSinceFirstVisit<=50 seem to have actually not valid segment values? I mean the visitorType wouldn't match those values I think. It be great if there was a segment definition like pageUrl=@ and then one or multiple URL encoded characters in the comparison string and this should actually match a value. Then we would know for sure that values are correctly forwarded and read by climulti.

@tsteur uses a new segment type, hopefully the next build will pass

@diosmosis I suppose the changed values in tests are because of the segment change?

@tsteur yes, matching less visits now

also,when testing I added the changes to 4.x-dev, then switched over and checked the test results were the same on this branch

👍 LGTM

after some debugging noticed this works eg because we urlencode the segment here: https://github.com/matomo-org/matomo/blob/3.14.1-b1/core/CronArchive.php#L841