Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI tests using embedded widgets #16298

Merged
merged 1 commit into from Aug 18, 2020
Merged

Fix UI tests using embedded widgets #16298

merged 1 commit into from Aug 18, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 14, 2020

Some UI tests were trying to embed widgets using a token_auth with more than view access.
Due to #16263 and #16264 that is only allowed for users with view access now.

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Aug 14, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Aug 14, 2020
@diosmosis diosmosis merged commit c9682a6 into 4.x-dev Aug 18, 2020
@diosmosis diosmosis deleted the fixuitests branch August 18, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur Awaiting requested review from tsteur

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis