Fix error when primary key is required #16290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
tsteur
commented
Aug 13, 2020
| $this->logAggregator->getDb()->exec('SET SESSION sql_require_primary_key=' . $val); | ||
| } catch (\Exception $e) { | ||
| if ($this->logAggregator->getDb()->isErrNo($e, 1193)) { | ||
| // ignore General error: 1193 Unknown system variable 'sql_require_primary_key' |
There was a problem hiding this comment.
seems to require mysql8 or so. works for me locally on mysql8
sgiehl
reviewed
Aug 14, 2020
sgiehl
approved these changes
Aug 17, 2020
|
How long will it take before this is released? Matomo is basically useless as it is now. |
|
@EmilMoe there will be a beta available likely in the next 2 weeks. The final release might be still 2 months or so away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://wordpress.org/support/topic/error-in-visits-over-time/
refs https://forum.matomo.org/t/matomo-on-digitalocean-managed-database-cluster-mysql-8-sql-require-primary-key-error/37623
Putting this into Matomo 4 since it is required for Matomo for WordPress as people can't change DB settings on wordpress.com etc.