@supervisitor opened this Issue on August 11th 2020

https://github.com/matomo-org/matomo/blob/679e73f1236969db0c2d767655cb84456a727d24/tests/PHPUnit/Integration/Tracker/TrackerCodeGeneratorTest.php#L68

in line 68, you should delete character 89 to 92 (amp;), this line should include ...matomo.php?idsite=1&rec=1... and not contain a ampersanded ampersand ...matomo.php?idsite=1&rec=1...

@tsteur commented on August 11th 2020 Member

@supervisitor thanks for creating the issue. Do you have an actual issue with the tracker generator? the double escaped & might be expected there.

@supervisitor commented on August 12th 2020

I think twice when I saw the result & in the generated tracker code.
Since then, I have been considering " and " on the same line... yes, I know the difference an reason for this &, but somewhere I suspect a nesting error.

I will double check tomorrow and come back with a more detailed report.

@tsteur commented on August 13th 2020 Member

Thanks. I just checked the regular output and there things look good see eg https://demo.matomo.org/index.php?module=API&format=json&method=SitesManager.getImageTrackingCode&idSite=62&period=day&date=yesterday and embedding eg

    <img src="//example.matomo/matomo.php?idsite=1&amp;rec=0" style="border:0" alt="" />

worked for me. It's only that in the tests it is encoded like this.

@supervisitor commented on August 15th 2020

Sorry, I'm not one to just carelessly submit an issue report. Please close it, this error happens only in a very special version and only installed here. 😳
Apologize again for the trouble I have caused.

@Findus23 commented on August 15th 2020 Member

No problem :slightly_smiling_face:

This Issue was closed on August 15th 2020
Powered by GitHub Issue Mirror