Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise Matomo 4 updates for better performance #16284

Merged
merged 4 commits into from Aug 14, 2020
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 11, 2020

For better performance we should combine as many queries into one ALTER table statement where possible. Technically there are also 2 drop user columns that could be combined but this table will be fast anyway and executing them individually may be better.

technically could also add all add columns and drop columns for each table together but not sure how much this impacts performance but would potentially make it quite a bit more difficult to implement maybe.

Any other thoughts?

@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Aug 11, 2020
@tsteur tsteur added this to the 4.0.0 milestone Aug 11, 2020
core/Updates/4.0.0-b1.php Outdated Show resolved Hide resolved
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Aug 11, 2020
@tsteur tsteur merged commit 4ed7544 into 4.x-dev Aug 14, 2020
@tsteur tsteur deleted the reorganiseupdates branch August 14, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants