Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomVariables users: how to keep BC and install the new plugin from Marketplace #16283

Closed
mattab opened this issue Aug 10, 2020 · 2 comments
Closed

CustomVariables users: how to keep BC and install the new plugin from Marketplace #16283

mattab opened this issue Aug 10, 2020 · 2 comments
Labels
invalid For issues or pull requests that are no longer relevant to Matomo core.
Milestone
4.0.0

Comments

@mattab
Copy link
Member

mattab commented Aug 10, 2020

Since we removed CustomVariables plugin from core: #16090 and #11524
and the Matomo 4 compatible version will be available from the Marketplace at https://plugins.matomo.org/CustomVariables soon,

I was wondering what happens on upgrade to Matomo 4:

  • will the custom variable plugin be disabled on one-click-upgrade, which might break BC for some users?
  • if the code is not deleted, then the problem is that the old CustomVariables code would not work (maybe?) with Matomo 4
  • could we maybe mention to users they need to install plugin from Marketplace? (for example when we see Custom Variables recent reports have some data set and they likely use the feature)

Created this ticket as a reminder to double check this upgrade flow and be clear, so we minimise support queries after upgrade.
@mattab mattab added this to the 4.0.0 milestone Aug 10, 2020
@sgiehl
Copy link
Member

sgiehl commented Aug 11, 2020

Shouldn't the plugin simply be updated if a newer version is available in the Marketplace 🤔

@tsteur
Copy link
Member

tsteur commented Aug 11, 2020

Closing this one. We had tested this already half a year ago see eg #15552 (comment) and we'll of course test all the updates from 2 different Matomo versions again before the beta.

refs #16165

@tsteur tsteur closed this as completed Aug 11, 2020
@tsteur tsteur added the invalid For issues or pull requests that are no longer relevant to Matomo core. label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid For issues or pull requests that are no longer relevant to Matomo core.
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @sgiehl