Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Tracker: Fix default value of heart beat timer #16282

Merged
merged 2 commits into from Aug 10, 2020
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 10, 2020

Documentation says the default should be 15, but actually if no value is given actually 5 would be always used.

Could be backported to 3.x-dev as well maybe

@sgiehl sgiehl added the Needs Review PRs that need a code review label Aug 10, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Aug 10, 2020
@sgiehl sgiehl assigned tsteur and unassigned tsteur Aug 10, 2020
@sgiehl sgiehl requested a review from tsteur August 10, 2020 13:19
@sgiehl
Copy link
Member Author

sgiehl commented Aug 10, 2020

build js

@sgiehl sgiehl changed the title Fix default value of heart beart timer Fix default value of heart beat timer Aug 10, 2020
@tsteur tsteur merged commit 467253f into 4.x-dev Aug 10, 2020
@tsteur tsteur deleted the fixheartbeatdefault branch August 10, 2020 19:54
@mattab mattab changed the title Fix default value of heart beat timer JS Tracker: Fix default value of heart beat timer Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants