Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer needed/used heartbeat code #16253

Merged
merged 3 commits into from Jul 31, 2020
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 29, 2020

Noticed heartBeatUp was actually no longer called since we refactored the heartbeat timer so this code should be possible to be removed

Noticed `heartBeatUp` was actually no longer called since we refactored the heartbeat timer so this code should be possible to be removed
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 29, 2020
@tsteur tsteur added this to the 4.0.0 milestone Jul 29, 2020
@tsteur
Copy link
Member Author

tsteur commented Jul 29, 2020

build js

@diosmosis diosmosis merged commit b93ae1f into 4.x-dev Jul 31, 2020
@diosmosis diosmosis deleted the heartbeattimerref branch July 31, 2020 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants