@gka opened this Issue on August 19th 2010 Contributor

I just found the CSS3PIE project, which aims to add CSS3 support to Internet Explorer 8 (and below). I tried this demo in IE8 and it works (rounded corners, css shadow).

Maybe we can integrate this into Piwik.

@robocoder commented on August 20th 2010 Contributor

There's diminishing value with IE9 approaching, but if CSS3PIE is compatible with jQuery/jQueryUI, and isn't noticeably slower for IE8 users, then it's fine with me.

@sgiehl commented on August 20th 2010 Member

As there are many big companies still using older browsers like IE7, we should try to optimize the layout for IE. As CSS3PIE works for IE 6,7 & 8 it might be a good choice. I already tried to integrate it and it seems to be quite easy.

@robocoder commented on August 20th 2010 Contributor

Assign the ticket so others know it's being worked on.

WRT browser support. Piwik supports older browsers (e.g., IE5 and above) in piwik.js, but for the dashboard/GUI, we only want to support newer releases otherwise the cross-browser regression testing (and maintenance for backward compatibility) becomes too burdensome. We also have to consider constraints by third-party libs (e.g., jQuery).

@sgiehl commented on August 23rd 2010 Member

CSS3PIE has a dual license: Apache-2 and/or GPL-2 (see http://github.com/lojjic/PIE/blob/master/LICENSE)

Are those licenses compatible with ours?

@robocoder commented on August 23rd 2010 Contributor

Fortunately, Apache 2 is compatible with GPL v3.

If it was dual licensed as Apache 2 or GPL (v2 or later), either would be fine.

@sgiehl commented on August 24th 2010 Member

Ok, fine. I will try to finish a first integration this weekend. If it works stable, I will commit it to trunk, so that others can test it before merging it to the 1.0 branch.

@sgiehl commented on August 29th 2010 Member

(In [3017]) refs #1625 added CSS3PIE to libs

@sgiehl commented on August 29th 2010 Member

(In [3018]) fixes #1625 added use of css3pie for ie
tested in ie 7 & 8

@robocoder commented on August 29th 2010 Contributor

(In [3019]) refs #1625 - update legal notice

@sgiehl commented on August 29th 2010 Member

(In [3020]) refs #1625 do not use css3pie for '.entityTable' - seems to crash IE

@mattab commented on August 30th 2010 Member

I tried trunk in IE8 but I don't see rounded corners (calendar, website selector etc.) is it expected?

@robocoder commented on August 30th 2010 Contributor

I'll fix that ... libs/CSS3PIE/PIE.php (a php proxy to server PIE.htc) is probably blocked by libs/.htaccess.

@julienmoumne commented on September 5th 2010 Member

(In [3061]) PIE.htc file is now served through piwik static file proxy. See #1527 for more info.

@robocoder commented on September 8th 2010 Contributor

Reference: http://css3pie.com/documentation/known-issues/
IE interprets the URL for the behavior property relative to the source HTML document, rather than relative to the CSS file like every other CSS property.

Is this why rounded corners only appears when the AssetManager is enabled?

@julienmoumne commented on September 13th 2010 Member

With ./libs/CSS3PIE/PIE.php, CSS3PIE works with AssetManager enabled and disabled.

I've been looking for a fix but I'm not even able to make it work like it used to, ie. with AssetManager enabled and using:

behavior: url("./index.php?module=CoreHome&action=getPieHtc")

I tried several ways to declare the file :

./index.php, /index.php, index.php, ../../index.php

I looked at any modifications made to Piwik::serveStaticFile() and couldn't find anything that would help me understand.

@robocoder commented on September 14th 2010 Contributor

Strange indeed. I'll reopen for investigation.

@robocoder commented on September 17th 2010 Contributor

(In [3157]) fixes #1625 - tested with assetmanger enabled and disabled

@robocoder commented on September 17th 2010 Contributor

Sorry, there are some unrelated changes in that commit. I tried to Ctrl-C that but was too late to abort the commit.

@robocoder commented on September 17th 2010 Contributor

[3158] reverts the last set of changes

@robocoder commented on September 17th 2010 Contributor

(In [3159]) refs #1625 - marking as fix; anomalies appear to be an internal cache issue with IE

@mattab commented on November 16th 2010 Member

I am using IE8, but I don't see any UI changes (rounded corners, etc.) after the changes in this ticket. Do you see any changes in IE8?

@robocoder commented on November 16th 2010 Contributor

This would be the cache "anomaly". Clearing the browser cache and restarting the browser helps. Make sure IE isn't in compatibility mode.

@mattab commented on November 24th 2010 Member

Cool, after fixing #1822 I now see the rounded corners in IE.
This CSSPIE library is very intriguing black magic :)

@mattab commented on February 15th 2011 Member

I just tried on the demo.piwik.org, with IE8, and I see a Javascript error message in PieHtc:

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Timestamp: Tue, 15 Feb 2011 02:49:38 UTC

Message: 'I.f().images' is null or not an object
Line: 54
Char: 44
Code: 0
URI: t

To replicate, go to dashboard, Add a widget, and hover over the items

@robocoder commented on February 16th 2011 Contributor

(In [3915]) refs #1625 - update to CSS3PIE 1.0beta3

@mattab commented on February 17th 2011 Member

It looks like it fixed it, no more errors in IE. thanks vipsoft!

This Issue was closed on February 17th 2011
Powered by GitHub Issue Mirror