Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use category display name for segment metadata #16242

Merged
merged 2 commits into from Jul 28, 2020
Merged

Use category display name for segment metadata #16242

merged 2 commits into from Jul 28, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 24, 2020

The display name of some categories have been changed in the past. e.g. Referrers was changed to Acquisition. The Segment selector still show Referrers at the moment, as the display name is not yet used there.

ping @tsteur @mattab

refs matomo-org/plugin-MarketingCampaignsReporting#46

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 24, 2020
@tsteur tsteur merged commit 8ca34b2 into 4.x-dev Jul 28, 2020
@tsteur tsteur deleted the segmentcat branch July 28, 2020 01:57
@mattab mattab added this to the 4.0.0 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants