@sgiehl opened this Pull Request on July 21st 2020 Member

shall we mention that change in the changelog?

refs #11524

@diosmosis commented on July 21st 2020 Member

Makes sense to me to mention in the changelog since this change will require a change on users that use the old setting.

@tsteur commented on July 21st 2020 Member

@sgiehl can we keep the *custom_variables configs but also add new *_custom_dimension settings? and run an update script that copies over existing values that may be configured to the new setting?

Then we probably don't need https://github.com/matomo-org/plugin-CustomVariables/pull/5 and things are more clear

@mattab commented on July 21st 2020 Member

btw, it would also need to be documented in https://matomo.org/faq/how-to/faq_54/

@sgiehl commented on July 22nd 2020 Member

@tsteur does it make sense to keep the *custom_variables settings in core, if we move the plugin out?
Added an update script that copies over the settings if they were configured locally before.

@tsteur commented on July 22nd 2020 Member

I don't have a big preference, can move it to the plugin. Would then just need to make sure in the plugin that the config values are set when they update as otherwise suddenly the default values would be missing. So need to try and set it maybe on Matomo 4 core update, but also in the plugin update additionally maybe?

@sgiehl commented on July 23rd 2020 Member

That's reason I've added a fallback to the *dimensions config values in the plugin. Those are defined by core after the update and will always be present if someone did not define the *variables config values before manually.

@tsteur commented on July 23rd 2020 Member

👍 can you fix the tests and then merge and close the ticket?

This Pull Request was closed on July 24th 2020
Powered by GitHub Issue Mirror