Backport userId to overwrite visitorId feature #16226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Pull Request WIP
tsteur
commented
Jul 21, 2020
| @@ -562,7 +562,18 @@ private function setIdVisitorForExistingVisit($valuesToUpdate) | |||
| // Might update the idvisitor when it was forced or overwritten for this visit | |||
| $valuesToUpdate['idvisitor'] = $this->request->getVisitorId(); | |||
| } | |||
|
|
|||
|
|
|||
| if (TrackerConfig::getConfigValue('enable_userid_overwrites_visitorid')) { | |||
There was a problem hiding this comment.
technically, this if might be no longer needed since we added above if in Matomo 4. However, the if above does not yet update $this->visitProperties->setProperty('idvisitor', $binIdVisitor); and I'm not sure why this is done and if it's needed so I added the entire if block
tsteur
added
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #15593
based on #16124
not adding any extra tests as default behaviour doesn't change and we have added tests in Matomo 4 already for both config values (enabled / disabled)