Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix start/end time for given period it can skip this archive #16221

Merged
merged 5 commits into from Jul 20, 2020
Merged

Fix start/end time for given period it can skip this archive #16221

merged 5 commits into from Jul 20, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 20, 2020 •
edited

fix #16220

fyi @diosmosis be good if you could have a look or maybe you remember if that caused any issue

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 20, 2020
@tsteur tsteur added this to the 4.0.0 milestone Jul 20, 2020
@tsteur tsteur mentioned this pull request Jul 20, 2020
Closed
@tsteur tsteur requested a review from diosmosis July 20, 2020 04:06
@diosmosis
Copy link
Member

@tsteur can you modify Period::getBoundsInTimezone()? there are unit tests for it.

@tsteur
Copy link
Member Author

tsteur commented Jul 20, 2020

@diosmosis sure pushing this right now

@diosmosis
Copy link
Member

the unit tests failed, are they incorrect?

@tsteur
Copy link
Member Author

tsteur commented Jul 20, 2020

Yes I think they aren't correct
image

@tsteur tsteur merged commit b04f693 into 4.x-dev Jul 20, 2020
@tsteur tsteur deleted the m16220 branch July 20, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Matomo 4: Browser archiving issue for today archive
2 participants
@tsteur @diosmosis