Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matomo 4: Browser archiving issue for today archive #16220

Closed
tsteur opened this issue Jul 20, 2020 · 0 comments · Fixed by #16221
Closed

Matomo 4: Browser archiving issue for today archive #16220

tsteur opened this issue Jul 20, 2020 · 0 comments · Fixed by #16221
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Jul 20, 2020

Custom ini settings:

[Debug]
always_archive_data_day = 1

[General]
time_before_today_archive_considered_outdated = 1

First I tracked a new page view

matomo.php?rec=1&idsite=1&action_name=foo&send_image=1

Timezone of the site is America/Los_Angeles

The log_visit.visit_last_action_time for this visit is 2020-07-20 01:41:44.

I then view the reports like this

index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=day&date=2020-07-19&segment=&category=General_Actions&subcategory=General_Pages

The date is 2020-07-19. However, nothing is being archived since Loader::canSkipThisArchive returns false because hasSiteVisitsBetweenTimeframe() returns false:

image

The to and from date is correct. However, in the UI I can't select the 20th July as this day as not started yet. My local time is 1:40PM July 20th NZST.

image

When using Matomo 3 everything seems to work as expected. Once I disable the canSkipThisArchive check, it starts the archiving. And interestingly it uses a different time:

image
image

and it is showing data for this report
image

It seems bit random that Matomo would use two different times? Somewhere the time is off?

The time that canSkipThisArchive used seems correct to me?
image

The LogAggregator class uses this method:
image

image

and canSkipThisArchive uses a different way as it uses this logic

image

Something seems off. Then realised skipThisArchive was creating the wrong time as it was generated the time for UTC 0am to 23:59 in the different timezone. When it should have created the UTC time for US/LA 0am to 23:59:

image

To make it short, skipThisArchive should use same logic as logaggregator see PR #16221

@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jul 20, 2020
@tsteur tsteur added this to the 4.0.0 milestone Jul 20, 2020
@tsteur tsteur self-assigned this Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant