Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language selector in mobile menu is not visible #16212

Merged
merged 1 commit into from Jul 17, 2020
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 15, 2020

When being anonymous, and opening the top menu in the mobile view then nothing is readable because it's white on light grey

When being anonymous, and opening the top menu in the mobile view then nothing is readable because it's white on light grey
@tsteur tsteur added the Needs Review PRs that need a code review label Jul 15, 2020
@tsteur tsteur added this to the 4.0.0 RC milestone Jul 15, 2020
@sgiehl
Copy link
Member

sgiehl commented Jul 15, 2020

Should we maybe add a UI test for the mobile menu? 🤔

@tsteur
Copy link
Member Author

tsteur commented Jul 15, 2020

It's fine it only affected it when someone had public viewing of data anonymous enabled.

@diosmosis diosmosis merged commit 38cf2ef into 4.x-dev Jul 17, 2020
@diosmosis diosmosis deleted the mobilelanguage branch July 17, 2020 00:10
@mattab mattab modified the milestones: 4.0.0-RC, 4.0.0 Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants