skip id segments option #16203
skip id segments option #16203
Conversation
| $segments = $segmentEditorModel->getAllSegmentsAndIgnoreVisibility(); | ||
|
|
||
| $segments = array_filter($segments, function ($segment) use ($idSegments) { | ||
| return (!in_array($segment['idsegment'], $idSegments)); |
There was a problem hiding this comment.
@mikkeschiren looks good so far. The only thing I'm wondering if we could also filter by idSite?
eg
in_array($segment['idsegment'], $idSegments) && (empty($segment['enable_only_idsite']) || $idSite == $segment['enable_only_idsite'])And then we could throw an exception if an idSegments were specified, but none matches any. This way it wouldn't by accident set no segments to force, and the user would be aware a wrong ID was set.
tsteur
added
Needs Review
|
@mikkeschiren are you able to apply the changes suggested by @tsteur ? |
|
Yeah, sorry, been occupied will look into this and change. |
|
@mikkeschiren sorry I have to close this issue. It cannot be merged as the logic changed quite a bit in Matomo 4. It will now need to be implemented in a so called Here is the method where it sets the segments https://github.com/matomo-org/matomo/blob/4.x-dev/core/CronArchive/ArchiveFilter.php#L124 and this is the code in the command: https://github.com/matomo-org/matomo/blob/4.x-dev/plugins/CoreConsole/Commands/CoreArchiver.php#L53-L56 It might be fairly easy to adopt the current code into this new way. Generally I would maybe not set |
No description provided.