@mikkeschiren opened this Pull Request on July 13th 2020
@sgiehl commented on July 24th 2020 Member

@mikkeschiren are you able to apply the changes suggested by @tsteur ?

@mikkeschiren commented on July 24th 2020

Yeah, sorry, been occupied will look into this and change.

@tsteur commented on August 31st 2020 Member

@mikkeschiren sorry I have to close this issue. It cannot be merged as the logic changed quite a bit in Matomo 4. It will now need to be implemented in a so called ArchiveFilter similar to https://github.com/matomo-org/matomo/blob/4.x-dev/core/CronArchive/ArchiveFilter.php#L64-L68

Here is the method where it sets the segments https://github.com/matomo-org/matomo/blob/4.x-dev/core/CronArchive/ArchiveFilter.php#L124 and this is the code in the command: https://github.com/matomo-org/matomo/blob/4.x-dev/plugins/CoreConsole/Commands/CoreArchiver.php#L53-L56

It might be fairly easy to adopt the current code into this new way.

Generally I would maybe not set $this->segmentsToForce but another property eg ArchiveFilter::$segmentsToSkip and a method ArchiveFilter::setSegmentsToSkip just to make sure there won't be any side effects as skip should maybe not force all other segments except for the skipped one but really rather only skip any segment that matches the skipped ones.

This Pull Request was closed on August 31st 2020
Powered by GitHub Issue Mirror