Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up change only triggering error when no start and end date is set #16201

Merged
merged 2 commits into from Jul 10, 2020
Merged

Follow up change only triggering error when no start and end date is set #16201

merged 2 commits into from Jul 10, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 10, 2020

refs #16172

fyi @sgiehl does this make sense?

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 10, 2020
@tsteur tsteur added this to the 4.0.0 milestone Jul 10, 2020
@tsteur tsteur requested a review from sgiehl July 10, 2020 00:05
@tsteur tsteur mentioned this pull request Jul 10, 2020
Merged
@sgiehl
Copy link
Member

sgiehl commented Jul 10, 2020

Then we need to set an end date for this live query:

matomo/plugins/Live/Model.php

Line 367 in d72b8bf

$segment = new Segment($segment, $idSite, $startDate, $endDate = null);

@tsteur
Copy link
Member Author

tsteur commented Jul 10, 2020

@sgiehl I was meaning it's fine if only end date or only start date is set. but not when both are empty, as this would be causing a full table scan.

@sgiehl
Copy link
Member

sgiehl commented Jul 10, 2020

Ok. Then it should be fine that way

@sgiehl sgiehl merged commit 610cb78 into 4.x-dev Jul 10, 2020
@sgiehl sgiehl deleted the m16172 branch July 10, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl