Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new dimension and segment whether cookies were used or not: "Profilable" #16192

Closed
tsteur opened this issue Jul 8, 2020 · 0 comments · Fixed by #16217
Closed

Add new dimension and segment whether cookies were used or not: "Profilable" #16192

tsteur opened this issue Jul 8, 2020 · 0 comments · Fixed by #16217
Assignees
@tsteur
Labels
c: Privacy For issues that impact or improve the privacy. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
4.0.0

Comments

@tsteur
Copy link
Member

tsteur commented Jul 8, 2020

With Matomo we've always had the ability to disable cookies or use cookies. Now we have added the ability to also enable cookies after they were enabled etc. This lets users track visitors with cookies disabled, but enable cookies when/if they give consent to use cookies.

When cookies are enabled, some reports become more accurate.

When the data is mixed from visitors with and without cookies in the same site, then it's hard to know which referrer data to trust for example.

That's why you'd want to segment the audience by whether cookies were used or not used.

  • We need to add a new dimension and segment to the log_visit table
  • We need to send a new tracking parameter whether cookies were used or not (based on configCookiesDisabled variable). We need to update the log_visit column onNewVisit and onExisitingVisit since it might change during a visit
  • We don't need to add a report for now
  • We can't reuse the existing cookie flag we have in the visits table because it tracks whether cookies are generally available but not whether they were actually used or not used

Not sure what naming to use. Ideally, the wording could also be applied for iOS/Android SDK etc. Eg they might have the same concept, but don't use cookies for storing a visitorId.
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Privacy For issues that impact or improve the privacy. labels Jul 8, 2020
@tsteur tsteur added this to the 4.0.0 RC milestone Jul 8, 2020
@tsteur tsteur self-assigned this Jul 17, 2020
@tsteur tsteur modified the milestones: 4.0.0 RC, 4.0.0 Jul 17, 2020
@tsteur tsteur mentioned this issue Jul 17, 2020
Merged
tsteur added a commit that referenced this issue Jul 27, 2020
@tsteur
Remove update script for new profilable dimension
1ac9e3e 
refs https://github.com/matomo-org/matomo/pull/16217/files#r456216141
refs #16192

Thought it's better to remove this update as the value might be set wrongly in case someone updates from 3.14.0 to 4.0.0. Wanted to remove this in the PR directly but forgot to do it. Think it's better to have the dimension unset before setting it potentially wrongly.  see https://github.com/matomo-org/matomo/pull/16217/files#r456216141

Was also thinking of changing it to `"UPDATE $logVisit SET profilable = config_cookie WHERE profilable is null and visit_last_action_time < 2020-07-08"` because nobody could have used 3.14.0 before first beta was released on 8th July but it would mean some visits have this dimension set while others don't and then it maybe becomes inconsistent. Could also add the date though.
@tsteur tsteur mentioned this issue Jul 27, 2020
Merged
tsteur added a commit that referenced this issue Jul 27, 2020
@tsteur
Remove update script for new profilable dimension (#16244)
2c584ec 
refs https://github.com/matomo-org/matomo/pull/16217/files#r456216141
refs #16192

Thought it's better to remove this update as the value might be set wrongly in case someone updates from 3.14.0 to 4.0.0. Wanted to remove this in the PR directly but forgot to do it. Think it's better to have the dimension unset before setting it potentially wrongly.  see https://github.com/matomo-org/matomo/pull/16217/files#r456216141

Was also thinking of changing it to `"UPDATE $logVisit SET profilable = config_cookie WHERE profilable is null and visit_last_action_time < 2020-07-08"` because nobody could have used 3.14.0 before first beta was released on 8th July but it would mean some visits have this dimension set while others don't and then it maybe becomes inconsistent. Could also add the date though.
@mattab mattab changed the title Add dimension and segment whether cookies were used or not Add new dimension and segment whether cookies were used or not: "Profilable" Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
c: Privacy For issues that impact or improve the privacy. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Add new dimension and segment "Profilable" (and new column log_visit.profilable) matomo-org/matomo
1 participant
@tsteur