Make Matomo more compatible with jQuery 3 #16187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
sgiehl
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs matomo-org/matomo-for-wordpress#314
Tested Matomo for WordPress with jQuery 3 but nothing was shown until I made these two changes. I added jQuery migrate to find this problem. JQuery migrate complained about this:
Once I made these two changes, Matomo seems to work nicely with jQuery 1, jQuery 2 and jQuery 3.
Whether we upgrade to jQuery 3, while still using jQuery 1 in Matomo for WordPress is still to be seen. I didn't do a full test so can't guarantee that everything works with jQuery 1 and 3 but it's a step in the right direction.