don't specify optional parameters before required parameters #16185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #16182 I suppose eventually we'll go over all of them since the IDE should be able to detect all usages
tsteur
added
not-in-changelog
|
Interestingly, since this is an API method, this ends up being a bit of a BC break (see the test failure). Will change the test. |
|
@diosmosis good one. Actually this needs to stay optional. I can switch the parameters |
|
Fixed the tests @diosmosis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #16182
I suppose eventually we'll go over all of them since the IDE should be able to detect all usages.