@tsteur opened this Pull Request on July 6th 2020 Member

refs https://github.com/matomo-org/matomo/pull/16182

I suppose eventually we'll go over all of them since the IDE should be able to detect all usages.

@diosmosis commented on July 7th 2020 Member

Interestingly, since this is an API method, this ends up being a bit of a BC break (see the test failure). Will change the test.

@tsteur commented on July 7th 2020 Member

@diosmosis good one. Actually this needs to stay optional. I can switch the parameters

@tsteur commented on July 7th 2020 Member

Fixed the tests @diosmosis

This Pull Request was closed on July 7th 2020
Powered by GitHub Issue Mirror