Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8 #16183

Closed
6 tasks done
Findus23 opened this issue Jul 6, 2020 · 3 comments
Closed
6 tasks done

Support PHP 8 #16183

Findus23 opened this issue Jul 6, 2020 · 3 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
4.0.0-RC

Comments

@Findus23
Copy link
Member

Findus23 commented Jul 6, 2020 •
edited by sgiehl

It is still quite a bit in the future until PHP 8 will be released, but as it is a major release removing and deprecating a lot of ancient features, one can not start early enough fixing things:

In Matomo:

matomo/core/Singleton.php

Lines 27 to 29 in 1155273

final private function __clone()
{
}

In 3rd-party-libraries:

  • PHP-DI: ReflectionParameter::getClass() is deprecated
[06-Jul-2020 13:56:34 UTC] PHP Deprecated:  Method ReflectionParameter::getClass() is deprecated in /home/lukas/public_html/matomophp8/vendor/php-di/php-di/src/DI/Invoker/FactoryParameterResolver.php on line 43

https://github.com/php/php-src/pull/5209
I still don't know DI, so I can't say much about it

Will be fixed with PHP-DI/PHP-DI#727 and #15974 (PR: #16311)

to be continued ...
@Findus23 Findus23 added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Jul 6, 2020
@Findus23 Findus23 mentioned this issue Aug 17, 2020
Merged
@sgiehl
Copy link
Member

sgiehl commented Aug 18, 2020

Private methods cannot be final as they are never overridden by other classes in /home/lukas/public_html/matomophp8/core/Singleton.php on line 27

Guess we could simply make the method public to prevent that error and maybe throw an Exception in the method that clone is not supported or something like that...

@Findus23 Findus23 mentioned this issue Oct 6, 2020
Closed
@tsteur tsteur added this to the 4.0.0-RC milestone Oct 6, 2020
@sgiehl sgiehl mentioned this issue Oct 8, 2020
Merged
@sgiehl
Copy link
Member

sgiehl commented Oct 13, 2020

Closing for now as there is nothing remaining atm.

@sgiehl sgiehl closed this as completed Oct 13, 2020
@Findus23
Copy link
Member Author

Now that I can test Matomo without getting hundreds of error messages per request, I can check the rest if something remains.
I'll reopen if I find something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.0.0-RC
Development

No branches or pull requests
3 participants
@tsteur @sgiehl @Findus23